doc: add initial doc on how to update cjs-module-lexer #43255
Conversation
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Review requested:
|
|
@guybedford I think this reflects what I understood from our discusison last week. Could you take a look to confirm? |
|
There's a link in the ESM docs that is supposed to be updated to match the version of the lexer being used: Line 1544 in 895cc57 |
Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@richardlau thanks, added that as a step. |
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95, I think automation is always good, but even if that existed, some doc that points to the automation which could then be the doocument for the specific steps still makes sense. I know I ran across some scripts in the repo that help to build some of the other dependencies but only ran across them by accident. Long way of saying that I think we need an entry point doc for each dependency to make other parts discoverable. If we had automation for everything and there was nothing else to say/explain then we might be able to consolidate into fewer docs. |
There was a problem hiding this comment.
Thanks for digging into this Michael.
As mentioned, at some point it may be worthwhile to run a recent Wasm build with fixed versions of the toolchain, note those toolchain versions and update the Wasm binary.
The project is very much in a maintenance mode and will only be getting bug fixes and not feature development going forward.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@aduh95 accepted all of your suggestions |
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
|
Landed in cc82f6f |
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Add some initial doc based on discussion with Guy
Bedford.
Signed-off-by: Michael Dawson mdawson@devrus.com